Adds protobuf serialization for LibLinear models#273
Merged
Conversation
pogren
approved these changes
Sep 20, 2022
Member
pogren
left a comment
There was a problem hiding this comment.
straightforward protobuf serialization has good test code coverage. I don't understand the purpose of the new methods in LibLinearModel: serializeModel, deserializeModels, and setField which have zero references and zero test code coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds protobuf serialization for liblinear models. Unfortunately rebuilding a LibLinear Model requires reflective access into the model as the fields are all package private with no setters, so we resort to using a
ByteArrayOutputStreamto serialize the model using Java serialization before packing it into a protobuf. The protobufs do exist for doing it with reflection, but it'll cause issues with the module system so it's not turned on.Motivation
We need to move Tribuo off Java serialization.